Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] driver.c got recompiled due to the order of methods changed #93680

Closed
fanyang-mono opened this issue Oct 18, 2023 · 1 comment · Fixed by #93894
Closed

[WASM] driver.c got recompiled due to the order of methods changed #93680

fanyang-mono opened this issue Oct 18, 2023 · 1 comment · Fixed by #93894
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
9.0.0

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Oct 18, 2023 •
edited
Loading

driver.c got recompiled during incremental build, when it shouldn't. This was triggered because the order of the methods in wasm_m2n_invoke.g.h changed. You could find the details by comparing the two wasm_m2n_invoke.g.h files from the first and second build.
invoke_files.zip

This issue was found in my PR (#90436).

Test failure log is here

Please re-enable corresponding tests upon fixing this.
@fanyang-mono fanyang-mono added the arch-wasm WebAssembly architecture label Oct 18, 2023
@fanyang-mono fanyang-mono added this to the 9.0.0 milestone Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

driver.c got recompiled during incremental build, when it shouldn't. This was triggered because the order of the methods in wasm_m2n_invoke.g.h changed. You could find the details by comparing the two wasm_m2n_invoke.g.h files from the first and second build.
invoke_files.zip

This issue was found in my PR (#90436).

Test failure log is here

Author: fanyang-mono
Assignees: radical
Labels:

arch-wasm
Milestone: 9.0.0

@fanyang-mono fanyang-mono mentioned this issue Oct 18, 2023
Merged
radical added a commit to radical/runtime that referenced this issue Oct 23, 2023
@radical
[wasm] InterpToNativeGenerator: sort signatures when emitting them
d62ae5b 
Fixes dotnet#93680 .
@radical radical mentioned this issue Oct 23, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 23, 2023
radical added a commit that referenced this issue Oct 23, 2023
@radical
[wasm] InterpToNativeGenerator: sort signatures when emitting them (#…
4c71cfb 
…93894)

Fixes #93680 .
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 23, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] InterpToNativeGenerator: sort signatures when emitting them radical/runtime
2 participants
@radical @fanyang-mono