-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SIMD for block inits with GC fields #102132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkRunner.Run<Bench>(args: args);
public class Bench
{
public struct MyStructWithGC
{
object gc;
long a; long b; long c; long d;
long e; long f; long g; long h;
}
MyStructWithGC _fld1;
MyStructWithGC _fld2;
[Benchmark]
public void Zeroing()
{
_fld1 = default;
_fld2 = default;
}
} |
|
@jakobbotsch @kunalspathak @dotnet/jit-contrib PTAL, diffs aren't too big |
Ping @jakobbotsch @kunalspathak @dotnet/jit-contrib 🙂 #102209 depends on it (for simpler diffs) |
jakobbotsch
approved these changes
May 15, 2024
kunalspathak
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83297
Currently, we conservatively give up on using SIMDs for structs (blocks) with GC references since SIMD (on x86/64 arch) has certain requirements to provide atomicity guarantees (data needs to be 16 byte aligned, CPU must support AVX2 and we must use aligned store instructions). Let's at least use SIMD for continuous non-GC parts of such structs, example:
Codegen diff: