[release/9.0] PersistedAssemblyBuilder: fix IL reference tokens to another generated assembly members #107691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit |
jkotas
approved these changes
Sep 11, 2024
artl93
approved these changes
Sep 11, 2024
artl93
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107661 to release/9.0
/cc @buyaa-n
Customer Impact
A customer reported that when they create two assemblies that depends one another the referenced member from other assembly appears as a member of current module and invoking such code throws
Regression
Not a regression, bug in the new PersistedAssemblyBuilder feature added in .NET 9.0
Testing
Unit tests that reproes the issue are added
Risk
Low, the fix is easy and clear, should not cause a regression