-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Fix analyzer tracking of nullable enums #110331
Merged
jeffschwMSFT
merged 3 commits into
release/9.0-staging
from
backport/pr-109430-to-release/9.0-staging
Jan 10, 2025
Merged
[release/9.0-staging] Fix analyzer tracking of nullable enums #110331
jeffschwMSFT
merged 3 commits into
release/9.0-staging
from
backport/pr-109430-to-release/9.0-staging
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/illink |
This is surfacing existing test failures, fixing in #110340. |
jeffschwMSFT
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 9.0.x
agocke
approved these changes
Jan 10, 2025
This was referenced Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-Tools-ILLink
.NET linker development as well as trimming analyzers
linkable-framework
Issues associated with delivering a linker friendly framework
Servicing-approved
Approved for servicing release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109430 to release/9.0-staging
/cc @sbomer
Customer Impact
Originally fixed in .NET 10 when found while investigating a related issue, and we got a customer report after the .NET 9 release. Customer reported via email when attempting to make an app NativeAOT and trim compatible. Impact is that there are unexpected analyzer warnings in source-generated code.
Simple example of a false positive warning customers could hit:
The actual customer-reported issue showed up in source-generated code not controlled by the customer, in a WinUI app:
for generated code like:
Regression
Testing
Added unit test which validates that the same pattern reported by the customer does not produces a warning.
Risk
Low. Analyzer-only change, doesn't impact runtime. Removes incorrect warnings produced by the trim analyzer.