Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] [apple-mobile] Disable TLSWitLoadedDlls for Apple mobile due to missing native libs #111356

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 13, 2025

Backport of #106461 to release/9.0-staging

/cc @matouskozak

Disable TLSWitLoadedDlls tests for Apple mobile due to missing native libs #92129.

Customer Impact

  • Customer reported
  • Found internally

CI only change.

Regression

  • Yes
  • No

The regression was introduced in #106052 and the test scenario was only disabled on main not servicing branches.

Testing

The failures didn't get caught because the tests are run only on runtime-extra-platforms pipeline.

Risk

Low: disabling unsupported failing test scenario to keep CI green.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 13, 2025
@matouskozak matouskozak added area-Infrastructure-mono os-ios Apple iOS and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 13, 2025
@matouskozak matouskozak self-assigned this Jan 13, 2025
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

@vitek-karas @jeffschwMSFT friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can treat this as tell mode

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Jan 13, 2025
@jeffschwMSFT jeffschwMSFT added this to the 9.0.2 milestone Jan 13, 2025
@matouskozak matouskozak merged commit 1975912 into release/9.0-staging Jan 14, 2025
97 of 118 checks passed
@jkotas jkotas deleted the backport/pr-106461-to-release/9.0-staging branch January 16, 2025 01:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono os-ios Apple iOS Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants