Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure - SendAsync_RequestVersion20_ResponseVersion20 #112232

Merged
merged 8 commits into from
Feb 7, 2025
Merged

Test failure - SendAsync_RequestVersion20_ResponseVersion20 #112232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb2b0b1
Trying to add user agent header.
rokonec Feb 6, 2025
1860fef
Test another way
rokonec Feb 6, 2025
cd4d568
Change server to httpbin
rokonec Feb 6, 2025
a0d5f2b
Merge branch 'main' into dev/rokonec/nopushserver-test-issue
rokonec Feb 7, 2025
e94b7f4
Merge branch 'main' into dev/rokonec/nopushserver-test-issue
rokonec Feb 7, 2025
2dfac00
Update Http2NoPushHost and add Http2NoPushGetUris for improved testing
rokonec Feb 7, 2025
875ab11
Merge branch 'dev/rokonec/nopushserver-test-issue' of https://github.…
rokonec Feb 7, 2025
11142c1
Merge branch 'main' into dev/rokonec/nopushserver-test-issue
rokonec Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/Common/tests/System/Net/Configuration.Http.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static partial class Http

// This server doesn't use HTTP/2 server push (push promise) feature. Some HttpClient implementations
// don't support servers that use push right now.
public static string Http2NoPushHost => GetValue("DOTNET_TEST_HTTP2NOPUSHHOST", "www.microsoft.com");
public static string Http2NoPushHost => GetValue("DOTNET_TEST_HTTP2NOPUSHHOST", "httpbin.org");

// Domain server environment.
public static string DomainJoinedHttpHost => GetValue("DOTNET_TEST_DOMAINJOINED_HTTPHOST");
Expand Down Expand Up @@ -106,6 +106,7 @@ public static Uri[] GetEchoServerList()

public static readonly object[][] Http2Servers = { new object[] { new Uri("https://" + Http2Host) } };
public static readonly object[][] Http2NoPushServers = { new object[] { new Uri("https://" + Http2NoPushHost) } };
public static readonly object[][] Http2NoPushGetUris = { new object[] { new Uri("https://" + Http2NoPushHost + "/get") } };

public static readonly RemoteServer RemoteHttp11Server = new RemoteServer(new Uri("http://" + Host + "/"), HttpVersion.Version11);
public static readonly RemoteServer RemoteSecureHttp11Server = new RemoteServer(new Uri("https://" + SecureHost + "/"), HttpVersion.Version11);
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public sealed class HttpClientHandler_RemoteServerTest : HttpClientHandlerTestBa

public static readonly object[][] Http2Servers = Configuration.Http.Http2Servers;
public static readonly object[][] Http2NoPushServers = Configuration.Http.Http2NoPushServers;
public static readonly object[][] Http2NoPushGetUris = Configuration.Http.Http2NoPushGetUris;

// Standard HTTP methods defined in RFC7231: http://tools.ietf.org/html/rfc7231#section-4.3
// "GET", "HEAD", "POST", "PUT", "DELETE", "OPTIONS", "TRACE"
Expand Down Expand Up @@ -1365,7 +1366,7 @@ public async Task SendAsync_RequestVersion20_ResponseVersion20IfHttp2Supported(U
}

[OuterLoop("Uses external servers")]
[ConditionalTheory(nameof(IsWindows10Version1607OrGreater)), MemberData(nameof(Http2NoPushServers))]
[ConditionalTheory(nameof(IsWindows10Version1607OrGreater)), MemberData(nameof(Http2NoPushGetUris))]
public async Task SendAsync_RequestVersion20_ResponseVersion20(Uri server)
{
// Sync API supported only up to HTTP/1.1
Expand Down
Loading