Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku: Initial runtime support #112323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trungnt2910
Copy link
Contributor

This contains a part of the code required to build CoreCLR and get paltests to pass on Haiku.

This commit covers native support code for the host and runtime libraries, which is located in src/native/**.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 10, 2025
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-native branch 2 times, most recently from b799675 to b7782cc Compare February 10, 2025 02:44
trungnt2910 and others added 2 commits February 10, 2025 14:33
- Checks for non-POSIX headers: `HAVE_SYS_STATFS_H` and `HAVE_MNTENT_H`.
- Checks for `sizeof(dirent::d_name)`.
- Checks for non-standard `struct statvfs::f_basetype` member.

These were removed in dotnet#103441 but required for Haiku builds.
This contains a part of the code required to build CoreCLR and get
`paltests` to pass on Haiku.

This commit covers native support code for the host and runtime
libraries, which is located in `src/native/**`.

Co-authored-by: Jessica Hamilton <[email protected]>
#define STRING_BUFFER_SIZE 8192

#ifdef __HAIKU__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be uses of both TARGET_HAIKU and __HAIKU__. Is there a reason we use one versus the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really... I just use the style that is more common in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants