Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clean up to debugger attribute tests #112450

Conversation

mrvoorhe
Copy link
Contributor

I missed a few places with

	[SetupLinkerKeepDebugMembers ("true")]

back when I landed #89011

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2025
@mrvoorhe
Copy link
Contributor Author

@sbomer Please take a look

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mrvoorhe
Copy link
Contributor Author

/ba-g "Unrelated timeouts"

I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```

back when I landed dotnet#89011
@mrvoorhe mrvoorhe force-pushed the remove-netfx-code-from-more-debugger-tests branch from d4b1cae to 6a6efbd Compare February 18, 2025 18:31
@mrvoorhe
Copy link
Contributor Author

@sbomer Can you merge the PR?

@sbomer sbomer merged commit e30fd97 into dotnet:main Feb 19, 2025
74 of 77 checks passed
grendello pushed a commit to grendello/runtime that referenced this pull request Feb 19, 2025
I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```

back when I landed dotnet#89011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants