Make linux-riscv nativeaot port robust #112736

am11 · 2025-02-20T12:53:10Z

Huge thanks to @filipnavara, all smoke tests are passing (except DwarfDump which currently doesn't account for per-architecture stats).

Contributes to #106223. We will run AOT libs tests next.

Co-authored-by: Filip Navara <[email protected]>

…keThunk

…e context

…size > PAGE_SIZE

…city guarantees of RhpCheckedXchg

…ount (to be reviewed)

filipnavara · 2025-02-21T14:40:46Z

@am11 I pushed changes addressing all the feedback save for #112736 (comment). Tested on device.

risc-vv · 2025-02-21T14:41:00Z

2fd845a is being scheduled for building and testing

GIT: 2fd845ad9515d7e1c5d4723580b2a97eba7388f0
REPO: dotnet/runtime
BRANCH: main

risc-vv · 2025-02-21T14:56:09Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 10min 40s 100ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 627597 / 655412 (95.76%)

=======================
      passed: 627597
      failed: 328
     skipped: 1462
      killed: 27487
------------------------
  TOTAL libs: 258
 TOTAL tests: 656874
   REAL time: 2h 26min 46s 569ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 622743 / 658502 (94.57%)

=======================
      passed: 622743
      failed: 144
     skipped: 1406
      killed: 35615
------------------------
  TOTAL libs: 258
 TOTAL tests: 659908
   REAL time: 2h 40min 23s 602ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 52s 616ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 21fc86a4b63aaf511fb5fbd6d7301655e597e3c8
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11 · 2025-02-21T15:35:23Z

Thank you! Tested after a clean build, haven't found any issue. 👍

risc-vv · 2025-02-21T20:17:01Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 7min 50s 713ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 0acb29dc604205cde6d41e60efcc1b8170764933
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 52s 458ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 0acb29dc604205cde6d41e60efcc1b8170764933
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 459134 / 495169 (92.72%)

=======================
      passed: 459134
      failed: 152
     skipped: 1456
      killed: 35883
------------------------
  TOTAL libs: 258
 TOTAL tests: 496625
   REAL time: 2h 54min 42s 914ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 0acb29dc604205cde6d41e60efcc1b8170764933
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 650948 / 679012 (95.87%)

=======================
      passed: 650948
      failed: 293
     skipped: 1398
      killed: 27771
------------------------
  TOTAL libs: 258
 TOTAL tests: 680410
   REAL time: 2h 26min 56s 577ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 0acb29dc604205cde6d41e60efcc1b8170764933
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S

...er.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunGenericHelperNode.cs

Co-authored-by: Tomasz Sowiński <[email protected]>

risc-vv · 2025-02-24T11:36:02Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 12min 57s 668ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 4b1889b52c5743258eb3db1188d699c90e3f1442
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 633426 / 666926 (94.98%)

=======================
      passed: 633426
      failed: 163
     skipped: 1477
      killed: 33337
------------------------
  TOTAL libs: 258
 TOTAL tests: 668403
   REAL time: 2h 43min 25s 256ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 4b1889b52c5743258eb3db1188d699c90e3f1442
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 52s 727ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 4b1889b52c5743258eb3db1188d699c90e3f1442
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 668311 / 700335 (95.43%)

=======================
      passed: 668311
      failed: 327
     skipped: 1579
      killed: 31697
------------------------
  TOTAL libs: 258
 TOTAL tests: 701914
   REAL time: 2h 23min 37s 128ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 4b1889b52c5743258eb3db1188d699c90e3f1442
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S

…R/Risc-V code)

am11 · 2025-02-24T17:49:06Z

@jkotas as you probably already know this but testing these changes is non-trivial on community platforms compared to official ones. It would be nice if bootstrapping work isn't blocked on minor details so we can do fast iterations to stabilize things. CoreCLR runtime is still getting riscv64 fixes after two years or so, I doubt we can fit and finish AOT in one go especially with broken infra. For ref, it is now passing more tests than LA64.

filipnavara · 2025-02-24T18:41:01Z

It would be nice if bootstrapping work isn't blocked on minor details so we can do fast iterations to stabilize things.

I would not necessarily call it a minor detail. Debugging memory order semantic errors postmortem is close to impossible because the observed effects are gone by the time you get into debugger. I for one appreciate feedback on this and if other reviewers give it more scrutiny.

I understand that you want to get this PR in quickly and so do I. I'm willing to spend time on addressing it now that I have some details still fresh in memory... (I have the fences fixed locally, just need to run tests on HW.)

jkotas · 2025-02-24T18:44:54Z

As I have said, my preference is to make the code just right where possible so that we do not have to go back to fix it again. If it is too hard (e.g. requires large scale refactoring), I would like to see wrong or sub-optimal code wrapped in TODOs and links to issues to ensure that these minor but important details do not fall through the cracks.

I am applying the same bar for both Microsoft and community contributions that go into main. For example, #112705 (comment)

risc-vv · 2025-02-24T19:06:06Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 5min 18s 69ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 78efdc7df09abf5b5371d7099c0725a82bdc6406
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 52s 558ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 78efdc7df09abf5b5371d7099c0725a82bdc6406
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 625826 / 663845 (94.27%)

=======================
      passed: 625826
      failed: 308
     skipped: 1453
      killed: 37711
------------------------
  TOTAL libs: 258
 TOTAL tests: 665298
   REAL time: 2h 22min 21s 251ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 78efdc7df09abf5b5371d7099c0725a82bdc6406
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 623413 / 649277 (96.02%)

=======================
      passed: 623413
      failed: 148
     skipped: 1454
      killed: 25716
------------------------
  TOTAL libs: 258
 TOTAL tests: 650731
   REAL time: 2h 42min 7s 120ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 78efdc7df09abf5b5371d7099c0725a82bdc6406
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

… and equivalent code in CoreCLR in ExchangeObject/CompareExchangeObject

risc-vv · 2025-02-24T20:11:07Z

RISC-V Release-CLR-VF2: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 5min 48s 894ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: d8486a6174f5ee81388319d64efb711fca7ba045
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 422942 / 452006 (93.57%)

=======================
      passed: 422942
      failed: 158
     skipped: 1411
      killed: 28906
------------------------
  TOTAL libs: 258
 TOTAL tests: 453417
   REAL time: 2h 56min 10s 662ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: d8486a6174f5ee81388319d64efb711fca7ba045
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9461 / 9537 (99.20%)

=======================
      passed: 9461
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9643
 TOTAL tests: 9643
   REAL time: 2h 45min 34s 698ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: d8486a6174f5ee81388319d64efb711fca7ba045
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 627508 / 655359 (95.75%)

=======================
      passed: 627508
      failed: 311
     skipped: 1453
      killed: 27540
------------------------
  TOTAL libs: 258
 TOTAL tests: 656812
   REAL time: 2h 23min 3s 188ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: d8486a6174f5ee81388319d64efb711fca7ba045
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11 · 2025-02-24T23:00:34Z

Added comments seems self-explanatory. All outstanding feedback is addressed. Let me know if there is something else.

am11 and others added 30 commits February 15, 2025 22:28

Fix AOT exception handling on linux-riscv64

1048e2e

Apply more suggestions

88ce95b

Co-authored-by: Filip Navara <[email protected]>

Fix unwind information for allocation helpers

59705b8

Restore correct FP registers in StackFrameIterator::UnwindFuncletInvo…

d116a11

…keThunk

Fix register addressing in GcInfoDecoder::GetRegisterSlot

b179a7f

Fix and enable software write watch

1cb6ced

Fix COOP frames layout

13953be

Fix indirections, comparison and other assembly for write barrier checks

53a4ef0

Fix cross-build on Risc-V host

c11dd62

Disable R2R in stage2 build

37680d7

Fix uninitialized value in RhpPInvoke

f861b44

Fix register in RhpPInvokeReturn

acab644

Initialize FP/RA pointers when creating StackFrameIterator from nativ…

de03a3e

…e context

Fix sign on PROLOG_SAVE_REG_PAIR_INDEXED

eb4449b

Fix more of the logic in write barriers. Needs further audit.

541ddb1

Fix incorrect unwinding information generated for methods with frame …

a0e1a83

…size > PAGE_SIZE

Fix emitting jump to bad slot helper

f48eae5

Fix unwind info for universal transitions

7734924

Fix comment

19c97fb

Fix flipped RA/FP in universal transition unwinding

c62c075

WIP: Rewrite thunk code generation

ea12bf4

WIP: Fix RhCommonStub

35a22b9

Fix layout of universal translation for unwinding

a719d7d

WIP: Add memory barriers to native AOT asm helpers (dotnet#106219)

212157a

WIP: Add fences to RhpCheckedLockCmpXchg/RhpCheckedXchg and fix atomi…

9743390

…city guarantees of RhpCheckedXchg

Preserve registers in INLINE_GET_TLS_VAR

20101ac

Preserve a7 as well

310e8f8

WIP: Attempt to fix masks in IsInProlog/TrailingEpilogueInstructionsC…

5b058e4

…ount (to be reviewed)

WIP: Fix GC hijacking flags and possible return value trashing

e5e96bb

Fix return value trashing

a5770dd

Update managed defintion of TransitionBlock too

2fd845a

Merge branch 'main' into feature/nativeaot/riscv64-port

21fc86a

am11 added 2 commits February 21, 2025 22:11

Update TLSDESC comments

84504b5

Merge branch 'main' into feature/nativeaot/riscv64-port

0acb29d

am11 requested review from tomeksowi and jkotas February 24, 2025 11:04

tomeksowi approved these changes Feb 24, 2025

View reviewed changes

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S Outdated Show resolved Hide resolved

...er.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunGenericHelperNode.cs Outdated Show resolved Hide resolved

am11 and others added 2 commits February 24, 2025 13:31

Update src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S

62c35d6

Co-authored-by: Tomasz Sowiński <[email protected]>

Merge branch 'main' into feature/nativeaot/riscv64-port

4b1889b

jkotas reviewed Feb 24, 2025

View reviewed changes

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S Show resolved Hide resolved

jkotas reviewed Feb 24, 2025

View reviewed changes

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S Show resolved Hide resolved

filipnavara added 2 commits February 24, 2025 16:14

Relax semantics of a fence in R2R helper to match ARM64

b3320a5

Add missing fence in RhpAssignRefRiscV64 (matches ARM code and CoreCL…

78efdc7

…R/Risc-V code)

Match barriers emitted by PalInterlockedOperationBarrier in NativeAOT…

d8486a6

… and equivalent code in CoreCLR in ExchangeObject/CompareExchangeObject

build-analysis bot mentioned this pull request Feb 25, 2025

Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173

Open

am11 requested a review from jkotas February 25, 2025 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make linux-riscv nativeaot port robust #112736

Make linux-riscv nativeaot port robust #112736

am11 commented Feb 20, 2025

filipnavara commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

am11 commented Feb 21, 2025

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 24, 2025 •

edited

Loading

am11 commented Feb 24, 2025

filipnavara commented Feb 24, 2025 •

edited

Loading

jkotas commented Feb 24, 2025

risc-vv commented Feb 24, 2025 •

edited

Loading

risc-vv commented Feb 24, 2025 •

edited

Loading

am11 commented Feb 24, 2025

Make linux-riscv nativeaot port robust #112736

Are you sure you want to change the base?

Make linux-riscv nativeaot port robust #112736

Conversation

am11 commented Feb 20, 2025

filipnavara commented Feb 21, 2025 • edited Loading

risc-vv commented Feb 21, 2025

risc-vv commented Feb 21, 2025 • edited Loading

am11 commented Feb 21, 2025

risc-vv commented Feb 21, 2025 • edited Loading

risc-vv commented Feb 24, 2025 • edited Loading

am11 commented Feb 24, 2025

filipnavara commented Feb 24, 2025 • edited Loading

jkotas commented Feb 24, 2025

risc-vv commented Feb 24, 2025 • edited Loading

risc-vv commented Feb 24, 2025 • edited Loading

am11 commented Feb 24, 2025

filipnavara commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 21, 2025 •

edited

Loading

risc-vv commented Feb 24, 2025 •

edited

Loading

filipnavara commented Feb 24, 2025 •

edited

Loading

risc-vv commented Feb 24, 2025 •

edited

Loading

risc-vv commented Feb 24, 2025 •

edited

Loading