-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SSA-based ComputeRange in assertprop #112824
Draft
EgorBo
wants to merge
14
commits into
dotnet:main
Choose a base branch
from
EgorBo:rngchk-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+305
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR calls SSA-based RangeCheck::GetRange in Assertprop where it's benficial. It's not cheap so I've placed it in strategic places under TP-driven conditions.
Diffs.
What this PR does:
GetRange
call anyway. Assertprop uses custom budgets (to improve TP).m_pCurBndsChk
field is replaced withValueNum m_preferredBound
because this is how it's used anyway (it's a hint for RangeCheck thatm_preferredBound
is more precise than a constant) - it's never used inside Assertprop uses.BBF_MAY_HAVE_BOUNDS_CHECKS
- this is 0 diff change with -0.1% TP improvement. BTW, currently rangecheck always analyzes even cold block - if we change that, we can get some nice TP wins.optAssertionProp_RangeProperties
(only ifonlyIfCheap
is false)optAssertionPropGlobal_RelOp
for "x relop cns" to catch various "impled" cases (which RBO didn't catch)X >= CNS
now creates[CNS...INT_MAX]
range instead of[CNS...UNKNOWN]
- this helpsDoesOverflow
to be a bit less conservative.The end goal is to be able to do things like this:
to be able to mark the mod as unsigned (since i never goes negative), so it's optimized into just
i & 7
. Same for other things where we might benefit from such knowledge - e.g. sign extension casts.Far future TODOs