Add logic for JsonIgnoreCondition.[Never|WhenNull] on properties to win over global IgnoreReadOnlyValues #34672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n over global IgnoreReadOnlyValues
layomia
added
area-System.Text.Json
breaking-change
steveharter
approved these changes
Apr 13, 2020
|
@layomia this is labeled breaking change. Can you please open an issue with https://github.com/dotnet/docs/issues/new?template=dotnet-breaking-change.md I don't see an existing one |
danmoseley
added
the
needs-breaking-change-doc-created
|
This was a breaking change between previews (3 & 4) for a new feature, so no breaking change documentation is needed here. |
layomia
removed
breaking-change
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options specified on properties should win over options set on
JsonSerializerOptions. This change affects serialization only.JsonIgnoreConditionwas introduced in #34049 and was part of preview 3. This change will thus be a behavorial breaking change between preview 3 & 4 (but will likely not be noticed).