-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that iOS builds get correct library identity for native libraries #43302
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Looks like the iOS arm64 build fails with:
We're indeed targetting iOS 7 for device builds and iOS 8 for simulator. @rolfbjarne do you know what this error means, should we use |
That's quite unfortunate. I think Xamarin itself uses |
Hm, |
Looks like this is usually a warning instead of an error but we're using warnings-as-errors so this gets turned into an error. |
We discussed on Discord and iOS 8 is fine as the minimum version these days. |
8.0 as the minimum version is fine for dynamic libraries or frameworks, it's not for static libraries, since we still support iOS 7.
Apple is dropping support for older simulators quite aggressively, so there's not much purpose in building for a simulator you can never use. On the other hand it's still possible to build for older device versions in Xcode. |
Fixes #34637
I am not 100% sure this is the right place to put it. The
otool -L
output now looks like this:/cc @akoeplinger @rolfbjarne