Fix StartInfo test #44392

danmoseley · 2020-11-08T19:49:18Z

Fix one of the tests in #44239
For the other, gather some small extra info -- but I have no theory why setting the apartment state is failing, if the version of Windows does support COM.

ghost · 2020-11-08T19:49:42Z

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.Windows.cs

src/coreclr/src/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs

src/mono/netcore/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs

Co-authored-by: Jan Kotas <[email protected]>

danmoseley · 2020-11-09T22:35:15Z

@dotnet/dnceng any thoughts here?
https://github.com/dotnet/runtime/pull/44392/checks?check_run_id=1376226460

gzip: stdin: unexpected end of file
/bin/tar: Unexpected EOF in archive
/bin/tar: Unexpected EOF in archive
/bin/tar: Error is not recoverable: exiting now

MattGal · 2020-11-10T00:04:59Z

@dotnet/dnceng any thoughts here?
https://github.com/dotnet/runtime/pull/44392/checks?check_run_id=1376226460
gzip: stdin: unexpected end of file
/bin/tar: Unexpected EOF in archive
/bin/tar: Unexpected EOF in archive
/bin/tar: Error is not recoverable: exiting now

Taking a look.

MattGal · 2020-11-10T00:08:17Z

@danmosemsft this is because only the first 141 MB of the artifact was downloaded, when if it had finished it would have made it to 376-ish MB, and of course they declared victory. When you go to untar it, it rightfully says that isn't a valid file.

I'll go find the issue about this, but I don't think they're likely to fix it any time soon.

danmoseley · 2020-11-10T00:11:08Z

So it's an Azure DevOps issue, and I should just retry?

MattGal · 2020-11-10T00:17:33Z

So it's an Azure DevOps issue, and I should just retry?

definitely so, still finding it (lots of IMs right now)

MattGal · 2020-11-10T00:20:57Z

No update in 109 days, but it's microsoft/azure-pipelines-tasks#13250 if you'd like to push on it.

danmoseley · 2020-11-10T23:48:42Z

@jkotas any other feedback?

src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs

jkotas · 2020-11-11T00:00:26Z

src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs

@@ -985,17 +981,15 @@ public void StartInfo_TextFile_ShellExecute()

                try
                {
-                    process.WaitForInputIdle(); // Give the file a chance to load
-                    Assert.Equal("notepad", process.ProcessName);
-
                    if (PlatformDetection.IsInAppContainer)


You can delete the whole IsInAppContainer block while you are on it.

jkotas

LGTM otherwise

danmoseley · 2020-11-11T01:29:26Z

I notice that this existing test adds up to 30 seconds to the time these tests take to run
https://github.com/danmosemsft/runtime/blob/202ab8072ae827e9b99c2fcfb9e2c4517b5696b0/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs#L640
If the goal of the large sleep is to ensure the process has started before waiting on it to exit, it might be better to do something like read something it writes to the output stream.

danmoseley · 2020-11-11T04:36:18Z

I fixed that, but there's two processes both launched by CreateProcessLong() that hold the console handles open preventing the test runner completing until they time out after 5 mins. I spent some time trying to find out which test was launching these and not killing them, but couldn't find it.

I did fix one place where dispose wasn't called, but it isn't the cause of the problem.

danmoseley · 2020-11-11T15:23:10Z

@akoeplinger Android timed out.

ghost · 2020-11-11T15:23:28Z

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

danmoseley · 2020-11-11T15:23:51Z

@jkotas can you sign off?

jkotas · 2020-11-11T17:19:03Z

src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs

@@ -639,13 +639,17 @@ public async Task WaitAsyncForSelfTerminatingChild()
        [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
        public async Task WaitAsyncForProcess()
        {
-            Process p = CreateSleepProcess(WaitInMS);
+            Process p = CreateProcessPortable(RemotelyInvokable.SleepWithWrite, "1000");
+            p.StartInfo.RedirectStandardOutput = true;


I am not able to figure out what this is trying to fix and why it works. Could you please elaborate?

I believe that this fix is not quite right. If the stdout buffer is small or non-existing, the test will hang. The process will be stuck on writing to stdout. This write will never end because of ReadToEnd that reads from other side of the pipe is done only after the process exits.

As written, WaitAsyncForProcess takes at least 30 seconds to complete. That is because it waits on the first to finish of: a process that sleeps for 30 seconds, and a 60 second delay. The other tests are mostly finished by the time it starts, so it causes the test run to wait that long. (Although, having mitigated that, there is a subsequent 5 minute delay as mentioned above)

If this delay was intentional I guess it was to try to avoid the process exiting before waiting on it to exit. So, I was hoping to find a way to block the child process from exiting until WaitForExitAsync() is called.

Can we make the test outer loop instead?

~~Perhaps I can use an event such as in WaitForSignal().~~

Sure, I'll do that for now.

Done, and opened issue.

danmoseley · 2020-11-12T00:36:22Z

Installer failure is #43917
Android failure is affecting many PR's and it already passed Android once.

danmoseley · 2020-11-12T00:37:54Z

Libraries checked coreclr Linux run is failed installer. I will try one more time.

danmoseley · 2020-11-12T00:38:41Z

@dotnet/dnceng is this known?

2020-11-11T19:22:15.5812153Z ./build.sh -subset libs.pretest -rc checked -configuration Debug -ci -arch x64 -framework net6.0  -testscope innerloop     /p:RuntimeArtifactsPath=/datadisks/disk1/workspace/_work/1/s/artifacts/transport/coreclr  /p:RuntimeFlavor=coreclr /bl:/datadisks/disk1/workspace/_work/1/s/artifacts/log/Debug/overrideRuntimeFromLiveDrop.binlog
2020-11-11T19:22:15.5813789Z ========================== Starting Command Output ===========================
2020-11-11T19:22:15.5830529Z [command]/bin/bash --noprofile --norc /datadisks/disk1/workspace/_work/_temp/7380dd9d-d004-4979-9473-813fcccc5b1a.sh
2020-11-11T19:22:16.2532395Z __DistroRid: linux-x64
2020-11-11T19:22:16.2533137Z __RuntimeId: linux-x64
2020-11-11T19:22:16.3034880Z Downloading 'https://dot.net/v1/dotnet-install.sh'
2020-11-11T19:22:16.3036139Z Trying to run 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh' for maximum of 5 attempts.
2020-11-11T19:22:16.5309775Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:16.5371274Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 3 seconds before next attempt (2 out of 5).
2020-11-11T19:22:19.7042576Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:19.7105078Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 7 seconds before next attempt (3 out of 5).
2020-11-11T19:22:26.8671014Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:26.8732443Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 15 seconds before next attempt (4 out of 5).
2020-11-11T19:22:42.0370656Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:42.0439145Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 31 seconds before next attempt (5 out of 5).
2020-11-11T19:23:13.2061439Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:23:13.2130659Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 63 seconds before next attempt (6 out of 5).
2020-11-11T19:24:16.2141463Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh' for 5 times.
2020-11-11T19:24:16.2212704Z ##[error](NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) Failed to acquire dotnet install script (exit code '1').
2020-11-11T19:24:16.2220776Z ##[error]Bash exited with code '1'.
2020-11-11T19:24:16.2242161Z ##[section]Finishing: Prepare TestHost with runtime CoreCLR

MattGal · 2020-11-12T17:26:50Z

@dotnet/dnceng is this known?

2020-11-11T19:22:15.5812153Z ./build.sh -subset libs.pretest -rc checked -configuration Debug -ci -arch x64 -framework net6.0  -testscope innerloop     /p:RuntimeArtifactsPath=/datadisks/disk1/workspace/_work/1/s/artifacts/transport/coreclr  /p:RuntimeFlavor=coreclr /bl:/datadisks/disk1/workspace/_work/1/s/artifacts/log/Debug/overrideRuntimeFromLiveDrop.binlog
2020-11-11T19:22:15.5813789Z ========================== Starting Command Output ===========================
2020-11-11T19:22:15.5830529Z [command]/bin/bash --noprofile --norc /datadisks/disk1/workspace/_work/_temp/7380dd9d-d004-4979-9473-813fcccc5b1a.sh
2020-11-11T19:22:16.2532395Z __DistroRid: linux-x64
2020-11-11T19:22:16.2533137Z __RuntimeId: linux-x64
2020-11-11T19:22:16.3034880Z Downloading 'https://dot.net/v1/dotnet-install.sh'
2020-11-11T19:22:16.3036139Z Trying to run 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh' for maximum of 5 attempts.
2020-11-11T19:22:16.5309775Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:16.5371274Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 3 seconds before next attempt (2 out of 5).
2020-11-11T19:22:19.7042576Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:19.7105078Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 7 seconds before next attempt (3 out of 5).
2020-11-11T19:22:26.8671014Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:26.8732443Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 15 seconds before next attempt (4 out of 5).
2020-11-11T19:22:42.0370656Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:22:42.0439145Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 31 seconds before next attempt (5 out of 5).
2020-11-11T19:23:13.2061439Z curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
2020-11-11T19:23:13.2130659Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 63 seconds before next attempt (6 out of 5).
2020-11-11T19:24:16.2141463Z Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh' for 5 times.
2020-11-11T19:24:16.2212704Z ##[error](NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) Failed to acquire dotnet install script (exit code '1').
2020-11-11T19:24:16.2220776Z ##[error]Bash exited with code '1'.
2020-11-11T19:24:16.2242161Z ##[section]Finishing: Prepare TestHost with runtime CoreCLR

Yes, I will add you to a thread.

danmoseley added 2 commits November 8, 2020 11:17

Stabilize StartInfo_NotepadWithContent_withArgumentList

fe7b2ea

Add state in failed SetApartmentState exception

b835e0b

Dotnet-GitSync-Bot added the area-Meta label Nov 8, 2020

danmoseley requested a review from wfurt November 8, 2020 19:49

danmoseley added area-System.Diagnostics.Process and removed area-Meta labels Nov 8, 2020

danmoseley added 4 commits November 8, 2020 12:00

Same for other tests

91ccc3f

Extract common code

605f442

Modify

fed4032

Extract common code

8c96e0a

jkotas reviewed Nov 9, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.Windows.cs Outdated Show resolved Hide resolved

Pass down throwOnError

6ff2627

danmoseley requested review from akoeplinger, EgorBo, marek-safar, steveisok and vargaz as code owners November 9, 2020 18:29

jkotas reviewed Nov 9, 2020

View reviewed changes

src/coreclr/src/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed Nov 9, 2020

View reviewed changes

src/coreclr/src/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed Nov 9, 2020

View reviewed changes

src/mono/netcore/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

202ab80

Co-authored-by: Jan Kotas <[email protected]>

runfoapp bot mentioned this pull request Nov 10, 2020

Inability to unzip assets during build on Unix x64 #32805

Closed

jkotas reviewed Nov 10, 2020

View reviewed changes

src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs Show resolved Hide resolved

jkotas reviewed Nov 11, 2020

View reviewed changes

feedback

1ef9cc6

danmoseley added the auto-merge label Nov 11, 2020

danmoseley removed the auto-merge label Nov 11, 2020

jkotas reviewed Nov 11, 2020

View reviewed changes

danmoseley added 2 commits November 11, 2020 10:01

Add process for disposal

a2ba656

Make slow test outer loop

7fba861

danmoseley force-pushed the notepadtest branch from 43269f1 to 7fba861 Compare November 11, 2020 18:10

danmoseley mentioned this pull request Nov 11, 2020

Process tests do not return for 5 minutes #44537

Closed

jkotas approved these changes Nov 11, 2020

View reviewed changes

danmoseley added the auto-merge label Nov 11, 2020

ghost merged commit a207c7f into dotnet:master Nov 12, 2020

danmoseley deleted the notepadtest branch November 12, 2020 03:46

ghost locked as resolved and limited conversation to collaborators Dec 12, 2020

danmoseley restored the notepadtest branch December 22, 2020 05:06

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix StartInfo test #44392

Fix StartInfo test #44392

danmoseley commented Nov 8, 2020

ghost commented Nov 8, 2020

danmoseley commented Nov 9, 2020

MattGal commented Nov 10, 2020

MattGal commented Nov 10, 2020

danmoseley commented Nov 10, 2020

MattGal commented Nov 10, 2020

MattGal commented Nov 10, 2020

danmoseley commented Nov 10, 2020

jkotas Nov 11, 2020

jkotas left a comment

danmoseley commented Nov 11, 2020

danmoseley commented Nov 11, 2020 •

edited

Loading

danmoseley commented Nov 11, 2020

ghost commented Nov 11, 2020

danmoseley commented Nov 11, 2020

jkotas Nov 11, 2020

danmoseley Nov 11, 2020

jkotas Nov 11, 2020

danmoseley Nov 11, 2020 •

edited

Loading

danmoseley Nov 11, 2020

danmoseley Nov 11, 2020

danmoseley commented Nov 12, 2020

danmoseley commented Nov 12, 2020

danmoseley commented Nov 12, 2020

MattGal commented Nov 12, 2020

Fix StartInfo test #44392

Fix StartInfo test #44392

Conversation

danmoseley commented Nov 8, 2020

ghost commented Nov 8, 2020

danmoseley commented Nov 9, 2020

MattGal commented Nov 10, 2020

MattGal commented Nov 10, 2020

danmoseley commented Nov 10, 2020

MattGal commented Nov 10, 2020

MattGal commented Nov 10, 2020

danmoseley commented Nov 10, 2020

jkotas Nov 11, 2020

Choose a reason for hiding this comment

jkotas left a comment

Choose a reason for hiding this comment

danmoseley commented Nov 11, 2020

danmoseley commented Nov 11, 2020 • edited Loading

danmoseley commented Nov 11, 2020

ghost commented Nov 11, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

danmoseley commented Nov 11, 2020

jkotas Nov 11, 2020

Choose a reason for hiding this comment

danmoseley Nov 11, 2020

Choose a reason for hiding this comment

jkotas Nov 11, 2020

Choose a reason for hiding this comment

danmoseley Nov 11, 2020 • edited Loading

Choose a reason for hiding this comment

danmoseley Nov 11, 2020

Choose a reason for hiding this comment

danmoseley Nov 11, 2020

Choose a reason for hiding this comment

danmoseley commented Nov 12, 2020

danmoseley commented Nov 12, 2020

danmoseley commented Nov 12, 2020

MattGal commented Nov 12, 2020

danmoseley commented Nov 11, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

danmoseley Nov 11, 2020 •

edited

Loading