Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes paths #45392

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Fixes paths #45392

merged 3 commits into from
Dec 3, 2020

Conversation

cshung
Copy link
Member

@cshung cshung commented Nov 30, 2020

Fixing the documentation or comments, All links or paths referring to src/coreclr/tests/src/... are now changed to src/tests/....

Some of the files are no longer there, such as runtests.[sh|cmd] or build_tests.[sh|cmd], they should also be fixed but I am not sure how.

@cshung cshung requested a review from trylek November 30, 2020 23:13
@cshung cshung mentioned this pull request Nov 30, 2020
Closed
trylek
trylek approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for putting these in sync! I did a pass over the docs in August I think but either I missed all of these (which would be embarrassing) or there's so much development around our docs (which would be encouraging).

@Maoni0
Copy link
Member

Maoni0 commented Nov 30, 2020

@cshung for building the stress test the instructions should be:

The easiest way to build the Framework+Tests is by running "dotnet msbuild" from <REPO_ROOT> on src\tests\GC\Stress\Framework\ReliabilityFramework.csproj.

@Maoni0 Maoni0 mentioned this pull request Nov 30, 2020
Closed
6 tasks
@cshung cshung force-pushed the public/fix-paths branch 2 times, most recently from 2bbe1b5 to 0f86783 Compare December 1, 2020 18:08
This was referenced Dec 2, 2020
Closed
Closed
@cshung cshung merged commit f7530ff into dotnet:master Dec 3, 2020
@cshung cshung deleted the public/fix-paths branch December 3, 2020 01:59
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 left review comments

@trylek trylek trylek approved these changes

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cshung @Maoni0 @trylek @Dotnet-GitSync-Bot