Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bounded channel to be created with drop delegate #50331

Merged
merged 11 commits into from
Mar 31, 2021
Merged

Allow bounded channel to be created with drop delegate #50331

merged 11 commits into from
Mar 31, 2021

Conversation

Temppus
Copy link
Contributor

@Temppus Temppus commented Mar 28, 2021

Fixes #36522
Add additional CreateBounded overload with delegate parameter that will be called when item is being dropped from channel
Added unit tests

@Temppus
Bounded channel can be created with drop delegate.
9494fa9 
- Add additional CreateBounded overload with delegate parameter that will be called when item is being dropped from channel
- Added unit tests
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 28, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #36522
Add additional CreateBounded overload with delegate parameter that will be called when item is being dropped from channel
Added unit tests

Author: Temppus
Assignees: -
Labels:

area-System.Threading.Channels, new-api-needs-documentation
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Mar 28, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

Temppus added 3 commits March 30, 2021 19:00
@Temppus
Drop delegate should not be called while sync lock is held.
f82accd 
Enqueuing of new item should be done while sync lock is being held.
Added additional tests.
@Temppus
Rerun gitlab CI.
327ff6a
@Temppus
Do not run deadlock test for bounded channels if platform do not supp…
000ac50 
…ort threading.
stephentoub
stephentoub approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit b47094d into dotnet:main Mar 31, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Threading.Channels new-api-needs-documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

API Proposal: Inform client code when a BoundedChannel drops an item
4 participants
@Temppus @dnfadmin @stephentoub @karelz