JIT: fix osr gc info this reporting #51057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the advent of dotnet#38229 an optimized method may need to report generics context via `this` while the un-optimzed version did not need to report. This impacts OSR, which previously was always trying to use the unoptimized root method frame reporting. Now under OSR we must sometimes add a slot to the OSR frame instead. Addresses one of the failure cases in dotnet#43534.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Apr 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of #38229 an optimized method may need to report generics
context via
thiswhile the un-optimzed version did not need to report.This impacts OSR, which previously was always trying to use the unoptimized
root method frame reporting. Now under OSR we must sometimes add a slot to
the OSR frame instead.
Addresses one of the failure cases in #43534.