Remove crossgen from superpmi tools #53958
Merged
+11
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
BruceForstall
requested changes
Jun 9, 2021
| @@ -903,21 +902,6 @@ def __init__(self, coreclr_args): | |||
|
|
|||
| """ | |||
|
|
|||
| if coreclr_args.host_os == "OSX": | |||
There was a problem hiding this comment.
Why did you remove these? the collection_shim_name and corerun_tool_name are still used.
There was a problem hiding this comment.
Sorry, that was by mistake. I meant to delete just a single line related to crossgen.
BruceForstall
approved these changes
Jun 9, 2021
|
Build failures seems to be unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #53458 has excluded
crossgen, this PR stops collecting superpmi collection forcrossgenand its references fromsuperpmi.py.