-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm workload name to wasm-tools
#55413
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect-to is defined here https://github.com/dotnet/designs/blob/main/accepted/2020/workloads/workload-manifest.md#redirects |
@joeloff throwing another feature into the mix |
@mhutch looks like dotnet/sdk#18166 isn't in yet? We can remove the redirect-to but there is a lot of existing tooling/instruction that uses the old name and things will break until they are updated. |
@lewing it looks like redirects won't make it for .NET 6 as we're not 100% confident they won't have unexpected side effects as currently implemented. I think we just have to take the breaking change while we're in preview, sorry :/ |
It's not a problem, I was just hoping to avoid breaking the world again this week. |
I'm going to land this later tonight unless there are strong objections. |
@naricc - possibly this affects the BDN Microbenchmark runs ? |
wasm-tools
Change
microsoft-net-sdk-blazorwebassembly-aot
towasm-tools
Every other workload in the file is abstract and probably shouldn't have a short name.