Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] Set EOS for 0-length response payload #60120

Merged
merged 1 commit into from
Oct 7, 2021
Merged

[HTTP/3] Set EOS for 0-length response payload #60120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,8 @@ private async ValueTask DrainContentLength0Frames(CancellationToken cancellation
case null:
// Done receiving: copy over trailing headers.
CopyTrailersToResponseMessage(_response!);

_responseDataPayloadRemaining = -1; // Set to -1 to indicate EOS.
return;
case Http3FrameType.Data:
// The sum of data frames must equal content length. Because this method is only
Expand All @@ -500,7 +502,7 @@ private async ValueTask DrainContentLength0Frames(CancellationToken cancellation
}
break;
default:
Debug.Fail($"Recieved unexpected frame type {frameType}.");
Debug.Fail($"Received unexpected frame type {frameType}.");
return;
}
}
Expand Down