Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Pass --dotnet-path to use dotnet-workload for wasm #66795

Merged
merged 2 commits into from
Mar 25, 2022
Merged

perf: Pass --dotnet-path to use dotnet-workload for wasm #66795

merged 2 commits into from
Mar 25, 2022

Conversation

radical
Copy link
Member

@radical radical commented Mar 17, 2022

This ensures that the the benchmarks project is always built with the same dotnet, avoid corrupted builds.

@radical radical added the arch-wasm WebAssembly architecture label Mar 17, 2022
@ghost ghost assigned radical Mar 17, 2022
@ghost
Copy link

ghost commented Mar 17, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This ensures that the the benchmarks project is always built with the same dotnet, avoid corrupted builds.

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical
Copy link
Member Author

radical commented Mar 17, 2022

Depends on dotnet/performance#2320

@radical radical mentioned this pull request Mar 17, 2022
Closed
@ghost
Copy link

ghost commented Mar 18, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This ensures that the the benchmarks project is always built with the same dotnet, avoid corrupted builds.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-libraries
Milestone: -

LoopedBard3
LoopedBard3 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided expected tests are successful in manual perf run.

@radical radical marked this pull request as ready for review March 21, 2022 20:21
@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Mar 21, 2022
@radical
Copy link
Member Author

radical commented Mar 25, 2022

We should merge this. The current sporadic crash on the pipeline is seen on main. This will move us closer to a correct build.

@radical radical merged commit 55f2045 into dotnet:main Mar 25, 2022
@radical radical deleted the perf-dotnet-path branch March 25, 2022 17:56
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@radical @radekdoulik
perf: Pass --dotnet-path to use dotnet-workload for wasm (dotnet#66795)
9654ea7 
This ensures that the the benchmarks project is always built with the same dotnet, avoid corrupted builds.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @lewing @LoopedBard3 @maryamariyan