Code

Implement Tar APIs#67883

Code

Merged

carlossanlop merged 48 commits intodotnet:maindotnet/runtime:mainfrom carlossanlop:tarcarlossanlop/runtime:tarCopy head branch name to clipboardApr 21, 2022

+9,939-42

Commits

Commits on Apr 16, 2022

• Implement Tar APIs

  carlossanlop

  committed
  e9fbcc9

  Copy full SHA for e9fbcc9

• Address some comment suggestions.

  carlossanlop

  committed
  0731cb2

  Copy full SHA for 0731cb2

• Add SystemFormatsTarTestData package dependency entries and versions.

  carlossanlop

  committed
  8f1f1af

  Copy full SHA for 8f1f1af

• Merge the major and minor p/invokes into a single one.

  carlossanlop

  committed
  10df463

  Copy full SHA for 10df463

• Address exception and nullability suggestions.

  carlossanlop

  committed
  da4af67

  Copy full SHA for da4af67

• Adjust tests for the latest suggestions.

  carlossanlop

  committed
  8710ceb

  Copy full SHA for 8710ceb

• Document elevation requirement to extract device files on Unix.

  carlossanlop

  committed
  76e484c

  Copy full SHA for 76e484c

• Add tests to verify extraction without elevation throws for device files. Rename file for TarFile Extraction to filesystem.

  carlossanlop

  committed
  c9c4d85

  Copy full SHA for c9c4d85

• Add separate expected mode for special files from assets (644).

  carlossanlop

  committed
  e0dafda

  Copy full SHA for e0dafda

• Bump assets version to one with the fix

  carlossanlop

  committed
  5b8392b

  Copy full SHA for 5b8392b

• Fix bugs and add tests for: timestamp conversion, extended attributes collection, V7 special handling

  carlossanlop

  committed
  a16d4d9

  Copy full SHA for a16d4d9

• Validate entry.Name chars before extracting

  carlossanlop

  committed
  7ca674e

  Copy full SHA for 7ca674e

• Remove some minor todo comments

  carlossanlop

  committed
  560b789

  Copy full SHA for 560b789

• Add missing numeric value for PAL_S_IFCHR and its static assert

  carlossanlop

  committed
  b3e5988

  Copy full SHA for b3e5988

• Bug fixes:

  Show description for c22a8e7
  carlossanlop

  committed
  c22a8e7

  Copy full SHA for c22a8e7

• Bug fix: GNU can have two different metadata entries in a row if the entry has a long link and a long path. Add logic to handle that and tests to verify this.

  carlossanlop

  committed
  d3e4f31

  Copy full SHA for d3e4f31

• Add test to verify entry with subdir segments gets extracted by TarFile even if directory entries do not exist for those segments.

  carlossanlop

  committed
  23caa17

  Copy full SHA for 23caa17

• Rename UnknownFormat resource string to TarInvalidFormat, include format value. Add tests to verify malformed archive.

  carlossanlop

  committed
  e0b0442

  Copy full SHA for e0b0442

Commits on Apr 17, 2022

• Bug fixes:

  Show description for b682576
  carlossanlop

  committed
  b682576

  Copy full SHA for b682576

• Embed paths to exception message string when extracting file to different folder than destination.

  carlossanlop

  committed
  9fd01c3

  Copy full SHA for 9fd01c3

• Bug fix: WriteEntry from file on Windows failing with V7 due to incompatible regular file entry type.

  carlossanlop

  committed
  7b0d8c3

  Copy full SHA for 7b0d8c3

• Bug fixes:

  Show description for f1d9b7b
  carlossanlop

  committed
  f1d9b7b

  Copy full SHA for f1d9b7b

Commits on Apr 18, 2022

• Use HAVE* in pal_io.c to detect library where makedev is available. Do explicit casts to prevent build failures in wasm.

  Show description for 0980fbd
  carlossanlop

  committed
  0980fbd

  Copy full SHA for 0980fbd

• Remove unnecessary TargetPlatformIdentifier override in src csproj.

  carlossanlop

  committed
  a28f3e5

  Copy full SHA for a28f3e5

• Small refactor of VerifyOverwriteFileIsPossible

  carlossanlop

  committed
  7f2e516

  Copy full SHA for 7f2e516

• Remove parameter nullchecks.

  carlossanlop

  committed
  3f71b60

  Copy full SHA for 3f71b60

• Remove test method for attaching debugger.

  carlossanlop

  committed
  cb855ed

  Copy full SHA for cb855ed

• Remove devmajor and devminor duplicate todo message

  carlossanlop

  committed
  dd40447

  Copy full SHA for dd40447

Commits on Apr 19, 2022

• Remove unused datetime method

  carlossanlop

  committed
  9a28f12

  Copy full SHA for 9a28f12

• TMP exception with failed timestamp info

  carlossanlop

  committed
  40097c6

  Copy full SHA for 40097c6

• Remove failing device major/minor checks for now

  carlossanlop

  committed
  b1e8dfc

  Copy full SHA for b1e8dfc

• add FieldLocations static class, with position of first byte of each header field.

  carlossanlop

  committed
  c11e434

  Copy full SHA for c11e434

• Use InvariantCulture when converting the utf8 string to a double.

  carlossanlop

  committed
  255ec96

  Copy full SHA for 255ec96

• Copying file used by ExtractToDirectory test that throws, so it doesn't show up as used by another process in other tests.

  carlossanlop

  committed
  8ae7788

  Copy full SHA for 8ae7788

• Remove unused test method that opens and returns a filestream. We don't want that or it could cause tests to block due to used file.

  Show description for d3cbdd2
  carlossanlop

  committed
  d3cbdd2

  Copy full SHA for d3cbdd2

• Use a single rented buffer to read a whole header record. Convert related methods to use span.

  Show description for 6b5d078
  carlossanlop

  committed
  6b5d078

  Copy full SHA for 6b5d078

• Use ArrayPool for writing.

  carlossanlop

  committed
  19eb98d

  Copy full SHA for 19eb98d

• Fix upper bound of DeviceMajor and DeviceMinor.

  carlossanlop

  committed
  69ca3e7

  Copy full SHA for 69ca3e7

• Remove async APIs from ref, comment them in src.

  carlossanlop

  committed
  b1a2d5a

  Copy full SHA for b1a2d5a

• Add issue to TODO comments

  carlossanlop

  committed
  fb644dd

  Copy full SHA for fb644dd

• Remove unused methods.

  carlossanlop

  committed
  cd40d62

  Copy full SHA for cd40d62

• Add InvariantCulture to double.ToString conversions.

  carlossanlop

  committed
  0ee2c33

  Copy full SHA for 0ee2c33

Commits on Apr 20, 2022

• Fix test parsing a double, ensure it uses invariant culture.

  carlossanlop

  committed
  58a3476

  Copy full SHA for 58a3476

• More tests parsing a double, ensure invariant culture comparison.

  carlossanlop

  committed
  fc0e568

  Copy full SHA for fc0e568

• Verify link targets when extracting to directory. Disallow extracting individual links.

  carlossanlop

  committed
  5d81577

  Copy full SHA for 5d81577

• Avoid advancing stream anymore if end markers were found and GetNextEntry keeps getting called.

  carlossanlop

  committed
  a52dfe4

  Copy full SHA for a52dfe4

• Add test that verifies stream is not advanced anymore after reading the first null entry.

  carlossanlop

  committed
  b227fa9

  Copy full SHA for b227fa9

Commits on Apr 21, 2022

• Fix bug preventing correct generation of full path for extraction. Add condition to symlink tests that checks if system can create symlinks.

  carlossanlop

  committed
  5745b9f

  Copy full SHA for 5745b9f