Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.DotNet.Helix.Sdk #68024

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 14, 2022

Extracted from #67771 to get the fix for #67349

Updates the WASM tests to always use net6.0 until we can upgrade to a net7.0 SDK.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned akoeplinger Apr 14, 2022
@akoeplinger akoeplinger requested a review from premun April 14, 2022 14:08
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should work

@akoeplinger
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger marked this pull request as ready for review April 14, 2022 15:58
@ghost
Copy link

ghost commented Apr 14, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Extracted from #67771 to get the fix for #67349

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure

Milestone: -

@steveisok steveisok self-requested a review April 14, 2022 16:04
@steveisok
Copy link
Member

@akoeplinger @premun Is there something wrong with the xharness bump?

I'm seeing this in some of the failed runs:

/usr/bin/python3 -u /datadisks/disk1/work/BF180A16/w/A18D0948/u/xharness-event-processor.py
/usr/bin/python3: can't open file '/datadisks/disk1/work/BF180A16/w/A18D0948/u/xharness-event-processor.py': [Errno 2] No such file or directory

@akoeplinger
Copy link
Member Author

There is an issue on the wasm DebuggerTests leg that blocks this yeah

@premun
Copy link
Member

premun commented Apr 15, 2022

Ignore the Python error, that one is normal for all wasm runs even though they were supposed to turn off the telemetry to hide it. Regardless it is harmless

@steveisok
Copy link
Member

Are you sure? Some of these legs have all passes in their testResults.xml, but yet are being flagged as a failure.

@premun
Copy link
Member

premun commented Apr 19, 2022

@steveisok can you show me an example?

@akoeplinger
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@premun
Copy link
Member

premun commented Apr 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@premun
Copy link
Member

premun commented Apr 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@premun
Copy link
Member

premun commented Apr 20, 2022

@akoeplinger the build is looking good so far. I believe it's going to finish green.

The one failing wasm leg is a failing test, I checked the logs

@akoeplinger
Copy link
Member Author

@premun not sure whether the two failing wasm jobs are real failures, they just print this which is weird:

Console log: 'normal-Invariant.Tests' from job 1a207a32-525d-408a-9972-8eb73eaf1dd3 (windows.amd64.server2022.open) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly-20220317203903-1ad56e8 on a002BY9
running %HELIX_CORRELATION_PAYLOAD%\scripts\2e67926377ad48d28d153418c420f78b\execute.cmd in C:\h\w\A091093F\w\9EB708DD\e max 3600 seconds

Output:

Exit Code:-900

@premun
Copy link
Member

premun commented Apr 20, 2022

@radical do you know what could be up with the two failing WASM legs? We are forcing .NET 6.0 SDK in this PR like I was describing

@akoeplinger
Copy link
Member Author

@premun I just looked at the run_py.log and it looks like an infrastructure issue with Docker to me:

2022-04-20T16:11:48.431Z	ERROR  	dockerhelper(234)	run	API Error attempting to talk to Docker Server:500 Server Error: Internal Server Error ("CreateComputeSystem b470dbaa253592a57acb6c7ff8844c3d06337e4a756be9d52be9b942f7fd80a0: The request is not supported.
(extra info: 

@akoeplinger
Copy link
Member Author

Yay, it's green ✅ 🎉

@premun thank you for digging into this!

@akoeplinger akoeplinger merged commit 2894f54 into dotnet:main Apr 21, 2022
@akoeplinger akoeplinger deleted the bump-helix-sdk branch April 21, 2022 12:21
directhex pushed a commit to directhex/runtime that referenced this pull request Apr 21, 2022
Extracted from dotnet#67771 to get the fix for dotnet#67349

Updates the WASM tests to always use net6.0 until we can upgrade to a net7.0 SDK.

Co-authored-by: Premek Vysoky <[email protected]>
premun added a commit that referenced this pull request Apr 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants