Disambiguate calli thunks based on full calling conventions #73359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
commented
Aug 4, 2022
| @@ -88,6 +88,14 @@ private static string GetFormatString(ExceptionStringID id) | |||
| return SR.InvalidProgram_Vararg; | |||
| case ExceptionStringID.InvalidProgramCallVirtFinalize: | |||
| return SR.InvalidProgram_CallVirtFinalize; | |||
| case ExceptionStringID.InvalidProgramNonStaticMethod: | |||
There was a problem hiding this comment.
Unrelated bug found by TestCallingConventions test.
There was a problem hiding this comment.
This probably fixed the dotnet/runtimelab#1135 issue. Thank you!
|
cc @dotnet/ilc-contrib |
MichalStrehovsky
approved these changes
Aug 5, 2022
| @@ -88,6 +88,14 @@ private static string GetFormatString(ExceptionStringID id) | |||
| return SR.InvalidProgram_Vararg; | |||
| case ExceptionStringID.InvalidProgramCallVirtFinalize: | |||
| return SR.InvalidProgram_CallVirtFinalize; | |||
| case ExceptionStringID.InvalidProgramNonStaticMethod: | |||
There was a problem hiding this comment.
This probably fixed the dotnet/runtimelab#1135 issue. Thank you!
src/coreclr/tools/Common/TypeSystem/Interop/UnmanagedCallingConventions.cs
Show resolved
Hide resolved
|
Linux arm failure is #73247 |
This was referenced Aug 5, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtimelab#153