Fix issues 73653, 73679, 73692 #73761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- verify_region_to_generation_map needs to skip read only segments as they are not represented in the region to generation map. - move check to verify the mark queue is empty from the destructor to a normal method, and add a call to that method at the end of the mark phase.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThere are really just two issues:
|
mangod9
approved these changes
Aug 11, 2022
This was referenced Aug 11, 2022
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are really just two issues:
verify_region_to_generation_map needs to skip read only segments as they are not represented in the region to generation map.
it's bad to check for an empty mark queue in the destructor - thus move that check from the destructor to a normal method, and add a call to that method at the end of the mark phase.
#73653, #73679, #73692