-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove instances of %S
#78894
Remove instances of %S
#78894
Conversation
@BruceForstall Does this output mean anything to you? I don't understand what failed or why. The full log is at https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-78894-merge-dcf126a5aef944a183/win-x64-2/1/console.9966e11b.log?helixlogtype=result.
|
The issue is that #78783 changed the JIT-EE GUID, so until the SuperPMI collections get refreshed (which takes about 7 hours), the superpmi-replay and superpmi-diffs pipelines will fail. (This is the job doing the refresh: https://dev.azure.com/dnceng/internal/_build/results?buildId=2055077&view=results) |
@BruceForstall Should we create a tracking issue so the system can tag the failure? |
I don't think so. The failure should self resolve soon, and any such failure indicates you've changed the JIT and should probably wait until the collection completes at which point you should re-run the failed pipelines. |
Change local `sFlags` to generic `szTempBuf`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Remove unnecessary "normalize" call.
Remove uses of some %ls flags.
The slow slog to removing
%S
usage in the code base.