Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Enable two networking tests #81895

Merged
merged 3 commits into from
Feb 10, 2023
Merged

[Android] Enable two networking tests #81895

merged 3 commits into from
Feb 10, 2023

Conversation

simonrozsival
Copy link
Member

This is a follow up to #81631, ref #79143

The assert in AndroidCryptoNative_RegisterRemoteCertificateValidationCallback was failing because of a race condition in SslStream.Android.cs:77 that called the initialization code twice.

@simonrozsival simonrozsival requested a review from wfurt February 9, 2023 15:43
@ghost ghost assigned simonrozsival Feb 9, 2023
@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a follow up to #81631, ref #79143

The assert in AndroidCryptoNative_RegisterRemoteCertificateValidationCallback was failing because of a race condition in SslStream.Android.cs:77 that called the initialization code twice.

Author: simonrozsival
Assignees: simonrozsival
Labels:

area-System.Net.Security
Milestone: -

@simonrozsival
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Feb 9, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a follow up to #81631, ref #79143

The assert in AndroidCryptoNative_RegisterRemoteCertificateValidationCallback was failing because of a race condition in SslStream.Android.cs:77 that called the initialization code twice.

Author: simonrozsival
Assignees: simonrozsival
Labels:

area-System.Net.Security, os-android
Milestone: -

wfurt
wfurt approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@simonrozsival
Copy link
Member Author

The System.Net.Sockets.Tests.DualModeConnectionlessReceiveMessageFrom. BeginReceiveMessageFromV4BoundToSpecificV6_NotReceived test is failing on main as well, it was most likely caused by #80715.

@simonrozsival simonrozsival merged commit bbb107b into dotnet:main Feb 10, 2023
@simonrozsival simonrozsival deleted the android-enable-ipv6-test branch February 10, 2023 09:24
@build-analysis build-analysis bot mentioned this pull request Feb 10, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees

@simonrozsival simonrozsival

Labels
area-System.Net.Security os-android
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrozsival @wfurt @karelz