[Mono] Intrinsify max/min on ARM64 with mini JIT #83468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
vargaz
reviewed
Mar 16, 2023
vargaz
approved these changes
Mar 16, 2023
jandupej
reviewed
Mar 16, 2023
vargaz
approved these changes
Mar 16, 2023
|
CI failures are not related to this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #80566
There isn't one intrinsics on ARM64 which could do max/min calculation when element type is 64 bit integer. They are being handled specially. I also enforced that
xbinopinstructions would always share the same register between the first input and the return, so that the special handling logic that I just mentioned could be simplified.This PR also include a fix to the test failure on main about
wrong maximal instruction length of instruction loadx_membase (expected 12, got 16)https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-64f9ff91aebe494083/System.Numerics.Vectors.Tests/1/console.646f09bc.log?helixlogtype=result