Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][jit] AndNot and ConditionalSelect Intrinsics #84677

Closed
wants to merge 0 commits into from

Conversation

LeVladIonescu
Copy link
Contributor

Contributes to #80566.

@@ -3889,6 +3889,14 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb)
arm_neon_neg (code, get_vector_size_macro (ins), get_type_size_macro (ins->inst_c1), dreg, sreg1);
}
break;
case OP_ARM64_BIC:
arm_neon_bic(code, get_vector_size_macro (ins), dreg, sreg1, sreg2);
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding conventions.

Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me, except the coding style that Zoltan pointed out. And please merge main to your branch to get my latest change before merging.

@LeVladIonescu LeVladIonescu deleted the intrinsics branch April 12, 2023 23:55
@LeVladIonescu LeVladIonescu restored the intrinsics branch April 12, 2023 23:58
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants