Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure the HWIntrinsic tests to run more selectively #84948

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

tannergooding
Copy link
Member

As we're adding more tests for AVX512 and similar, we're more regularly hitting timeouts.

Given we already have extensive coverage across all the various stress legs (which disable intrinsics entirely or per-ISA) and the across the full breadth of Linux vs Windows vs OSX, I've opted to just not run some tests on particular platforms entirely.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2023
@tannergooding tannergooding marked this pull request as ready for review April 17, 2023 20:10
@tannergooding
Copy link
Member Author

CC. @kunalspathak, @trylek. This does roughly what got discussed in #83980

This becomes more relevant with #84909

Its possible we could filter xarch more, such as by splitting Sse-Sse4.2, Avx/Avx2/Fma, and Avx512+ to effectively be split or move some to outerloop, but that's a bit harder to rationalize given the new EVEX encoding support that impacts all instructions.

@tannergooding tannergooding force-pushed the hwintrin-test-timeout branch from ab1a1db to 60fea3e Compare April 17, 2023 20:17
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants