Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid null ref in JsonSeparatorNamingPolicy #85002

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Apr 18, 2023

Fixes dotnet/aspnetcore#47835.

@dotnet/area-system-text-json

@layomia layomia added this to the 8.0.0 milestone Apr 18, 2023
@layomia layomia requested a review from tarekgh April 18, 2023 19:22
@layomia layomia self-assigned this Apr 18, 2023
@ghost
Copy link

ghost commented Apr 18, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/aspnetcore#47835.

@dotnet/area-system-text-json

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json

Milestone: 8.0.0

@layomia layomia force-pushed the naming-policy-null-check branch from d2b5df8 to 2c104e4 Compare April 20, 2023 18:39
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI issues are addressed.

@layomia layomia force-pushed the naming-policy-null-check branch from aee943d to f49e0bd Compare April 21, 2023 16:41
@layomia layomia merged commit 966d36a into dotnet:main Apr 21, 2023
@layomia layomia deleted the naming-policy-null-check branch May 11, 2023 18:04
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SystemTextJsonValidationMetadataProvider passes null values to the JsonNamingPolicy
5 participants