Upgrade System.Reflection.Metadata version #85738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a response to #85038, I am upgrading
SystemReflectionMetadataVersion
from 6.0.0 to 7.0.0.As a side effect of this change, I also need to upgrade
SystemCollectionsImmutableVersion
from 6.0.0. to 7.0.0.These MSBuild properties are repo-wide. Fortunately, there are only a handful number of references for them. Broadly there are two classes, general-purpose library or tools, and MSBuild Tasks.
These are general-purpose libraries or tools. They could be used in some other contexts (e.g. ILCompiler.Reflection.ReadyToRun is currently used by ILSpy) and we should check if the upgrade would break those scenarios (We checked that ILSpy can work with the upgrade)
These are all MSBuild tasks, so they probably should have the same constraint and be consistent across. Note that both dotnet/msbuild and dotnet/sdk has already moved on with their upgrade to 7.0.0, and therefore upgrading here is probably the right thing to do to match. @ViktorHofer, do you know who/how to verify if the upgrade is safe for these projects?
CI validation indicates that this change is safe within this repo, the only failure found in the run are known test failures.
@dotnet/crossgen-contrib for awareness.