Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not establish a heap hard limit for 32 bit platforms #85844

Merged
merged 1 commit into from
May 19, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented May 5, 2023

This fixed #85757, a regression I introduced during the refactoring for #83707, the code to establish a heap hard limit under a container should be excluded for 32-bit platforms.

@cshung cshung self-assigned this May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixed a regression I introduced during the refactoring for #83707, the code to establish a heap hard limit under a container should be excluded for 32-bit platforms.

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

@mangod9
Copy link
Member

mangod9 commented May 6, 2023

so there is no way to specify a hard limit on 32-bit? Has that always been the case?

@cshung
Copy link
Member Author

cshung commented May 6, 2023

so there is no way to specify a hard limit on 32-bit? Has that always been the case?

Yes, we should not have a heap_hard_limit for 32-bit. In fact, we asserted that fact at the beginning of gc_heap::virtual_commit.

@cshung cshung merged commit 6508071 into dotnet:main May 19, 2023
@cshung cshung deleted the public/fix-ifdef branch May 19, 2023 20:34
@janseris
Copy link

janseris commented Jun 6, 2023

The error #85757 also happens when deploying as self-contained to Azure App Service with win-x86 (which is selected by default in Visual Studio publish profile when you select self-contained).
Self-contained must be used to include .NET 8 Preview 4 runtime with the app because it is not availble in the Azure App Service machine out of the box.

In my case, it was Blazor Server app.

And interestingly, I cannot select x64:

image

So I had to create a new app service on Linux x64 which does not have available free tier (F1) (only S1).

@cshung
Copy link
Member Author

cshung commented Jun 6, 2023

The error #85757 also happens when deploying as self-contained to Azure App Service with win-x86 ...

@janseris, is there something you want us to help you with? This bug is already fixed and merged into the main branch, it will be available in the next preview.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants