Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some code after the interface inheritance work #86347

Merged
merged 1 commit into from
May 16, 2023

Conversation

jkoritzinsky
Copy link
Member

Do some code cleanup:

  • Remove unused usings
  • Delete dead code
  • Unnest types
  • Remove outdated TODOs
  • Fix incorrect diagnostics
  • Refactor ComMethodContext to cache some of its work and prevent multiple calculations.

I recommend reviewing with whitespace changes disabled.

Do some code cleanup:

- Remove unused usings
- Delete dead code
- Unnest types
- Remove outdated TODOs
- Fix incorrect diagnostics
- Refactor ComMethodContext to cache some of its work and prevent multiple calculations.

I recommend reviewing with whitespace changes disabled.
@jkoritzinsky jkoritzinsky requested a review from jtschuster May 16, 2023 18:53
@ghost ghost assigned jkoritzinsky May 16, 2023
@jkoritzinsky
Copy link
Member Author

Looks like some of this code is might be in use with #86344

@jtschuster
Copy link
Member

Looks like some of this code is might be in use with #86344

We can merge this first, I'll re-add everything that PR needs after.

Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkoritzinsky jkoritzinsky merged commit 41274d0 into dotnet:main May 16, 2023
@jkoritzinsky jkoritzinsky deleted the code-cleanup branch May 16, 2023 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants