Enable event pipe tests in NativeAOT CI run #86389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 18, 2023
LakshanF
changed the title
LakshanF
requested review from
davmason,
jkoritzinsky,
MichalStrehovsky and
elinor-fung
elinor-fung
reviewed
May 18, 2023
elinor-fung
reviewed
May 18, 2023
elinor-fung
reviewed
May 19, 2023
| @@ -4,7 +4,7 @@ | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <!-- Tracing tests routinely time out with jitstress and gcstress --> | |||
| <GCStressIncompatible>true</GCStressIncompatible> | |||
| <JitOptimizationSensitive>true</JitOptimizationSensitive> | |||
| <JitOptimizationSensitive Condition="'$(TestBuildMode)' != 'nativeaot'">true</JitOptimizationSensitive> | |||
There was a problem hiding this comment.
Is this just because we don't want the environment variable check since in never matters for nativeaot? If so, can we just update the infrastructure to not add the check for nativeaot (similar to how it is skipped for mono)?
There was a problem hiding this comment.
Oops missed this comment, sorry! yep, it makes sense to change the check in infrastructure, will push a change for this
elinor-fung
approved these changes
May 19, 2023
This was referenced May 19, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables 2 tracing tests to run in NativeAOT validating EventPipe:
The CI results can be seen here with SimpleProviderValidation and RuntimeCounters.
There was an old PR #84891 related to this that was closed since it was old.