Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for PredefinedCulturesOnly in CultureInfo LCID .ctor #87002

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Account for PredefinedCulturesOnly in CultureInfo LCID .ctor #87002

merged 3 commits into from
Jun 2, 2023

Conversation

OwnageIsMagic
Copy link
Contributor

Fixes #86878

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 1, 2023
@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86878

Author: OwnageIsMagic
Assignees: -
Labels:

area-System.Globalization
Milestone: -

@OwnageIsMagic
Copy link
Contributor Author

@dotnet-policy-service agree

This was referenced Jun 1, 2023
Closed
Open
@tarekgh
Copy link
Member

tarekgh commented Jun 1, 2023

@OwnageIsMagic could you please add a test case in the file https://github.com/dotnet/runtime/blob/main/src/libraries/System.Globalization/tests/Invariant/InvariantMode.cs?

@tarekgh tarekgh added this to the 8.0.0 milestone Jun 1, 2023
@tarekgh tarekgh added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 1, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 2, 2023
@build-analysis build-analysis bot mentioned this pull request Jun 2, 2023
Closed
@OwnageIsMagic OwnageIsMagic requested a review from tarekgh June 2, 2023 14:35
@OwnageIsMagic OwnageIsMagic marked this pull request as draft June 2, 2023 14:36
@OwnageIsMagic OwnageIsMagic marked this pull request as ready for review June 2, 2023 14:38
@tarekgh
Copy link
Member

tarekgh commented Jun 2, 2023

@OwnageIsMagic I left a small suggestion, LGTM otherwise.

@tarekgh tarekgh merged commit f4ef5c8 into dotnet:main Jun 2, 2023
@OwnageIsMagic
Copy link
Contributor Author

@tarekgh Thanks!

@OwnageIsMagic OwnageIsMagic deleted the patch-1 branch June 2, 2023 18:57
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-System.Globalization community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

PredefinedCulturesOnly=false not respected in new CultureInfo(int)
2 participants
@OwnageIsMagic @tarekgh