Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing link libraries in host components #87042

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

elinor-fung
Copy link
Member

  • All host components link against dl - effectively, this handles hostfxr, hostpolicy, and nethost which were missing it
  • hostpolicy links against pthread

Fixes #43036

Checked that before this change, ld reported undefined references and a C program that just dlopens the shared libraries failed with undefined symbols and after this change, they succeed.

@ghost
Copy link

ghost commented Jun 2, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
  • All host components link against dl - effectively, this handles hostfxr, hostpolicy, and nethost which were missing it
  • hostpolicy links against pthread

Fixes #43036

Checked that before this change, ld reported undefined references and a C program that just dlopens the shared libraries failed with undefined symbols and after this change, they succeed.

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung added this to the 8.0.0 milestone Jun 2, 2023
@elinor-fung elinor-fung merged commit 0c85307 into dotnet:main Jun 2, 2023
@elinor-fung elinor-fung deleted the host-missing-link branch June 2, 2023 18:19
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libhostpolicy.so requires pthread_create but does not include it
3 participants