-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for tizen in ilc and crossgen2 #90310
Conversation
@sbomer Could you please take a look? (This condition was introduced with the switch to Mariner-backed official builds.) |
@@ -15,7 +15,7 @@ | |||
<!-- Disable native AOT on FreeBSD when cross building from Linux. --> | |||
<NativeAotSupported Condition="'$(TargetOS)' == 'freebsd' and '$(CrossBuild)' == 'true'">false</NativeAotSupported> | |||
<PublishAot Condition="'$(NativeAotSupported)' == 'true'">true</PublishAot> | |||
<SysRoot Condition="'$(NativeAotSupported)' == 'true' and '$(CrossBuild)' == 'true' and '$(HostOS)' != 'windows'">$(ROOTFS_DIR)</SysRoot> | |||
<SysRoot Condition="'$(NativeAotSupported)' == 'true' and '$(CrossBuild)' == 'true' and '$(HostOS)' != 'windows' and $(OutputRID.StartsWith('tizen')) != 'true'">$(ROOTFS_DIR)</SysRoot> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition is becoming more complex and it is dupicated in 4 places. Should we move it to more central location to deduplicate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to remake the solution to use NativeAotSupported
condition on the advice of @sbomer and not to complicate the state of the SysRoot
condition.
Is the AOT'd ILCompiler expected to run on tizen? Since the tizen build is a cross-build with a tizen rootfs, I think it makes sense to honor the CrossBuild setting here (without knowing much else about the tizen build). If the intention is to avoid producing an AOT'd crossgen to run on tizen, maybe it would be better to add the condition to |
2650eee
to
6bd871f
Compare
Yes, it is expected to work in the future. Created the solution with |
@sbomer Does this look good to you as well? |
Fix tizen x64 build error:
Create tizen x64 rootfs
sudo ./eng/common/cross/build-rootfs.sh x64 tizen
Build command:
ROOTFS_DIR=/home/runtime/.tools/rootfs/x64 ./build.sh --portablebuild false --cross --clang --arch x64 --runtimeConfiguration Release --librariesConfiguration Release --subset clr.native+clr.corelib+clr.tools+clr.nativecorelib+clr.packages+clr.nativeaotlibs+clr.crossarchtools+libs.native /p:EnableSourceLink=false /p:UseSharedCompilation=false
cc @gbalykov @alpencolt @t-mustafin