-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [mono] Enable System.IO.Hashing
tests on ios and disable them on tvos
#91195
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #90984 to release/8.0 /cc @ivanpovazan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Tagging subscribers to this area: @directhex Issue DetailsBackport of #90984 to release/8.0 /cc @ivanpovazan Customer ImpactThis change contributes towards having a green TestingThis can be verified by inspecting whether RiskThis is a CI infrastructure change with low risk. IMPORTANT: If this backport is for a servicing release, please verify that:
|
/azp run runtime-ioslike |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
@marek-safar @jeffschwMSFT - this one is ready as well, needs your approval. This ensures a cleaner CI on tvos, while enabling the test on iOS. No code product changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. this can be merged when ready
cc @carlossanlop - this is ready to be merged |
Backport of #90984 to release/8.0
/cc @ivanpovazan
Customer Impact
This change contributes towards having a green
runtime-extra-platforms
pipeline by keeping the same test coverage on iOS-like platforms.Testing
This can be verified by inspecting whether
System.IO.Hashing.Tests
have been ran and passed as part ofios-arm64 Release AllSubsets_Mono
job (e.g., https://helix.dot.net/api/jobs/a48cda4a-ca96-46e6-a3c0-43c11ea1a441/workitems?api-version=2019-06-17).Additionally, it should be verified that the
tvos-arm64 Release AllSubsets_Mono
is not running theSystem.IO.Hashing.Tests
testsRisk
This is a CI infrastructure change with low risk.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.