Revert Options source generator nullable annotation changes for Validator.TryValidateValue #91305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator.TryValidateValue
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsFollow-up from #91286 and related to #91162 Per a post-merge comment, the source generator changes for this nullable annotation need to be left as-is for now since the generator can target net6 and net7 where the #91286 is going to be backported to release/8.0 with #91293. Once merged, this PR will be augmented to that backport PR.
|
stephentoub
approved these changes
Aug 30, 2023
tarekgh
approved these changes
Aug 30, 2023
jeffhandley
added a commit
that referenced
this pull request
Aug 30, 2023
…ator.TryValidateValue (#91305)
carlossanlop
pushed a commit
that referenced
this pull request
Aug 31, 2023
…and ValidateValue (#91293) * Fix nullable annotation for Validator.TryValidateValue and ValidateValue * Revert Options source generator nullable annotation changes for Validator.TryValidateValue (#91305) * Fix nullable annotation for Validator.ValidateValue ref source (#91351) --------- Co-authored-by: Jeff Handley <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #91286 and related to #91162
Per a post-merge comment, the source generator changes for this nullable annotation need to be left as-is for now since the generator can target net6 and net7 where the
Validatorannotations were incorrect. Additional work on that source generator might introduce the ability to omit the!when targeting net8+, but this PR simply reverts the omission of the!for now.#91286 is going to be backported to release/8.0 with #91293. Once merged, this PR will be augmented to that backport PR.