-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] [NativeAOT] Switch macOS to mmap thunks like iOS platforms #92136
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #91751 to release/8.0 /cc @jkotas @filipnavara Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. this can be merged when ready
@filipnavara @jkotas there is a NativeAOT failure in osx-x64. Is it related to this change? https://github.com/dotnet/runtime/pull/92136/checks?check_run_id=16837406532 |
Looks like this change very slightly increases the size of the executable. I assume that's expected? Because we now have to reserve a page for the thunks? |
Yes, it is expected. We have not seen this issue in main because of it has other size reducing changes. |
Backport of #91751 to release/8.0
/cc @jkotas @filipnavara
Customer Impact
Apps published as native AOT do not work with hardened runtime on macOS. It is regression relative to regular CoreCLR w/ JIT that prevents native AOT compiled apps from being published on the app store.
Testing
Ad hoc testing.
Risk
Medium. The change itself is small, but it enables hundreds of lines of low-level code. that have been used for iOS.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.