Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle binding to initialized abstract members #93090

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Oct 6, 2023

Fixes #92137

If an abstract member is encountered in an object graph we should only throw if it's not already initialized.

If an abstract member is encountered in an object graph we should only
throw if it's not already initialized.
@ghost
Copy link

ghost commented Oct 6, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92137

If an abstract member is encountered in an object graph we should only throw if it's not already initialized.

Author: ericstj
Assignees: -
Labels:

area-Extensions-Configuration

Milestone: -

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericstj ericstj merged commit 4dcad85 into dotnet:main Oct 6, 2023
@ericstj
Copy link
Member Author

ericstj commented Oct 6, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6432589288

@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigurationBinder source generator throws on an abstract member rather than binding to existing value
2 participants