Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new nativeaot files to the platform manifest #93181

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add new nativeaot files to the platform manifest #93181

merged 1 commit into from
Oct 8, 2023

Conversation

lewing
Copy link
Member

@lewing lewing commented Oct 7, 2023 •
edited
Loading

#91038 caused the official build to fail https://dev.azure.com/dnceng/internal/_build/results?buildId=2285567&view=logs&j=1c10cb4a-4b1f-5dd9-3ecf-f4bf860ca96c&t=fce58ae7-1d52-5960-3c80-bf99aa5956a2&l=2360 this is just based off reading the error message

##[error].packages/microsoft.dotnet.sharedframework.sdk/8.0.0-beta.23463.1/targets/sharedfx.targets(294,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) The following files are missing entries in the templated manifest:
libstandalonegc-disabled.a
libstandalonegc-enabled.a. Add these file names with extensions to the 'PlatformManifestFileEntry' item group for the runtime pack and corresponding ref pack to include them in the platform manifest.

@ghost ghost assigned lewing Oct 7, 2023
@lewing lewing requested review from jkotas and cshung October 7, 2023 23:23
@lewing lewing mentioned this pull request Oct 7, 2023
Merged
9 tasks
@lewing lewing requested a review from artl93 October 7, 2023 23:27
@lewing lewing merged commit 6370dfe into dotnet:main Oct 8, 2023
@lewing lewing deleted the add-missing-nativeaot-files branch October 8, 2023 00:19
@cshung
Copy link
Member

cshung commented Oct 9, 2023

@lewing, do we need to do the same for Windows or OSX?

@lewing
Copy link
Member Author

lewing commented Oct 12, 2023

@lewing, do we need to do the same for Windows or OSX?

This appears to have been enough

@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artl93 artl93 artl93 approved these changes

@jkotas jkotas Awaiting requested review from jkotas

@cshung cshung Awaiting requested review from cshung

Assignees

@lewing lewing

Labels
area-Infrastructure-installer blocking-official-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @cshung @artl93