Arm64: Update certain encodings of instructions to make them size agnostic #94104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhile working on the tool to parse the Arm64 encoding xmls, I realized that there were some typos in the comments of our instruction table. Also, for certain instructions, I have updated the hex codes to be more generalized specially around size field. During encoding, we overwrite them anyhow and making them general would match with the encodings the tool parses from xml file. Contributes to #93095
|
kunalspathak
changed the title
This was referenced Oct 31, 2023
|
@dotnet/jit-contrib @BruceForstall PTAL |
BruceForstall
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the tool to parse the Arm64 encoding xmls, I realized that there were some typos in the comments of our instruction table. Also, for certain instructions, I have updated the hex codes to be more generalized specially around size field. During encoding, we overwrite them anyhow and making them general would match with the encodings the tool parses from xml file.
Contributes to #93095