-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 encodings for group IF_SVE_BH_3A,3B,3B_A #98764
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCovers encodings for a few SVE variants of the Matching capstone output:
Contributing towards #94549.
|
@a74nh @kunalspathak @dotnet/arm64-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
(EDIT: Didn't mean to approve until the change is made)
src/coreclr/jit/emitarm64.cpp
Outdated
ssize_t imm, | ||
insOpts opt /* = INS_OPTS_NONE */, | ||
emitAttr attrReg2 /* = EA_UNKNOWN */) | ||
void emitter::emitIns_R_R_R_I(instruction ins, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't needed as your not touching this function otherwise.
f49a738
to
c4547b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@snickolls-arm - can you please pull the latest |
superpmi failures seems to be infra issue. |
Covers encodings for a few SVE variants of the
adr
instruction.Matching capstone output:
Contributing towards #94549.