Fix NuGet packages #140
Merged
Fix NuGet packages #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Linux NuGet package wasn't including the static libraries. * The non-RID-specific package had RID specific stuff in it.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
approved these changes
Oct 2, 2020
jkotas
reviewed
Oct 2, 2020
| @@ -101,8 +101,7 @@ | |||
| <ItemGroup Condition="'$(PackageRID)' != ''"> | |||
| <LibrariesRuntimeFiles Condition="'%(IsNative)' != 'true'" TargetPath="runtimes/$(PackageRID)/lib/$(NetCoreAppCurrent)" /> | |||
| <LibrariesRuntimeFiles Condition="'%(IsNative)' == 'true'" TargetPath="$([System.String]::new('runtimes/$(PackageRID)/native/%(LibrariesRuntimeFiles.NativeSubDirectory)%(RecursiveDir)').TrimEnd('/'))" /> | |||
| <ReferenceCopyLocalPaths Include="@(LibrariesRuntimeFiles)" | |||
| Condition="'%(LibrariesRuntimeFiles.Extension)' != '.a'"/> | |||
| <ReferenceCopyLocalPaths Include="@(LibrariesRuntimeFiles)" /> | |||
There was a problem hiding this comment.
Add a link to the unification tech debt issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this is basically a revert of dotnet/runtime#41966. I got lost in trying to figure out what the .depsproj architecture is trying to achieve so I'm planning to just add this to the unification tech debt issue as we merge this.