Fix the list of RIDs supported by ILCompiler #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLapounov
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Mar 8, 2021
src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/Directory.Build.props
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue with
runtime.jsonfile inMicrosoft.DotNet.ILCompilerpackage that currently lists all 15 runtimes supported by .NET 6 while we build runtime ILCompiler packages for 6 RIDs only (#630 (comment)).We have to set the
RIDPropsFileproperty before importingsrc/installer/pkg/projects/Directory.Build.propsto avoid using RIDs listed insrc/installer/pkg/projects/netcoreappRIDs.props.The output of
dotnet publish -r win-x86before the fix:Determining projects to restore... ! Z:\Test\HelloWorld.csproj : error NU1101: Unable to find package runtime.win-x86.Microsoft.DotNet.ILCompiler. No packages exist with this id in source(s): dotnet-experimental, nuget Failed to restore Z:\Test\HelloWorld.csproj (in 838 ms).After the fix:
Determining projects to restore... Restored Z:\Test\HelloWorld.csproj (in 496 ms). You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview HelloWorld -> Z:\Test\bin\Debug\net5.0\win-x86\HelloWorld.dll ! Z:\Test\pkg\microsoft.dotnet.ilcompiler\6.0.0-preview.3.21153.3\build\Microsoft.NETCore.Native.Publish.targets(59,5): error : win-x86 not supported yet. https://github.com/dotnet/corert/issues/4589 [Z:\Test\HelloWorld.csproj]