Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolveNuGetPackageAssets allocates 3.7% of solution-wide design-time build #1605

Closed
davkean opened this issue Sep 26, 2017 · 4 comments
Closed

ResolveNuGetPackageAssets allocates 3.7% of solution-wide design-time build #1605

davkean opened this issue Sep 26, 2017 · 4 comments
Assignees
@nguerrera
Labels
performance
Milestone
2.1.3xx

Comments

@davkean
Copy link
Member

davkean commented Sep 26, 2017 •
edited
Loading

This is literally turning text -> text, can we do this without NewtonSoft.Json? Otherwise, try the lower level reader API that JSON.NET has?
image
@davkean davkean mentioned this issue Sep 26, 2017
Closed
@davkean davkean changed the title ResolveNuGetPackageAssets allocations 3.7% of solution-wide design-time build ResolveNuGetPackageAssets allocates 3.7% of solution-wide design-time build Sep 26, 2017
@davkean
Copy link
Member Author

davkean commented Oct 4, 2017

Some of this allocations is due to reading line annotations - turn that off via JsonLoadSettings.LineInfoHandling.

@nguerrera
Copy link
Contributor

This is the version of package resolution for non-SDK projects. cc @Pilchie Does this go in project-system or nuget?

@nguerrera nguerrera self-assigned this Feb 5, 2018
@Pilchie
Copy link
Member

Pilchie commented Feb 5, 2018

project-system has tended to make the changes, but the code lives at https://github.com/NuGet/NuGet.BuildTasks/.

@livarcocc livarcocc added this to the 2.1.3xx milestone Feb 9, 2018
@nguerrera nguerrera mentioned this issue Mar 30, 2018
Closed
@nguerrera
Copy link
Contributor

This issue was moved to NuGet/Home#6755

@nkolev92 nkolev92 mentioned this issue Apr 22, 2020
Open
JL03-Yue pushed a commit that referenced this issue Mar 19, 2024
@dotnet-bot
Merge pull request #1605 from dotnet/merges/release/6.x-to-main
4f3842e 
Merge release/6.x to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nguerrera nguerrera

Labels
performance
Projects
None yet
Milestone
2.1.3xx
Development

No branches or pull requests
4 participants
@nguerrera @Pilchie @livarcocc @davkean