Checkin editor config #1589
Merged
Checkin editor config #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
requested review from
johnbeisner,
livarcocc,
nguerrera and
dsplaisted
livarcocc
approved these changes
Sep 18, 2017
Why did you remove this one? I'd rather we just follow what corefx does so we don't have to be debating each rule. |
|
@nguerrera i recall people don't like that rules first time i try to check in the editor config. and we don't follow that in existing code anyway |
JL03-Yue
pushed a commit
that referenced
this pull request
Mar 19, 2024
…9e7-8ba9-afcadb357693 [release/6.x] Update dependencies from dotnet/roslyn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/corefx/blob/master/.editorconfig
The suggestion from VS can be much better. And I removed the rule of static type need s_ in the beginning