Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24068] Remove Legacy -- behavior and use of UnparsedTokens #26761

Merged

Conversation

Tunduk
Copy link
Contributor

@Tunduk Tunduk commented Jul 22, 2022

@baronfel Hi! I messed up with branches a little, so here is a new PR. Sorry for this, I'll be more careful in next time.
Link for history

@Tunduk
Copy link
Contributor Author

Tunduk commented Jul 22, 2022

@baronfel
Could you help me, please? On my local PC Microsoft.DotNet.Tools.Tool.Install is passed ok but in CI there are errors.
Am I doing something wrong?

@baronfel
Copy link
Member

@Tunduk looks like flakiness on those tests in the CI environment. I've seen the same recently. I restarted the 2 failed runs.

@baronfel baronfel added this to the 7.0.1xx milestone Jul 22, 2022
@baronfel baronfel added Area-CLI cli-ux Issues and PRs that deal with the UX of the CLI (exit codes, log output, verbs/options, and so on) labels Jul 22, 2022
@baronfel
Copy link
Member

Alright! @marcpopMSFT this is good to merge, I've done all the local testing I was concerned about.

@marcpopMSFT
Copy link
Member

@baronfel can you click the approve button so when I merge and everything breaks, I have a paper trail back to you? :P

@marcpopMSFT marcpopMSFT merged commit 72bb603 into dotnet:main Jul 22, 2022
@marcpopMSFT
Copy link
Member

Thank you for your contribution!

@baronfel
Copy link
Member

And thank you for sticking with it @Tunduk!

@baronfel
Copy link
Member

@Tunduk it looks like this may have regressed dotnet test a bit (see the linked microsoft/vstest issue). I'm going to dig into it a bit today and see if I can determine the cause.

@nagilson
Copy link
Member

nagilson commented Nov 3, 2022

This is the first time I've seen @marcpopMSFT use :P and I am very intrigued. More importantly, I don't see the issue attached in reference to this:

see the linked microsoft/vstest issue

Was it this? microsoft/vstest#4014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI Area-Infrastructure cli-ux Issues and PRs that deal with the UX of the CLI (exit codes, log output, verbs/options, and so on)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants