Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn #37781

Closed
wants to merge 14 commits into from
Closed

[main] Update dependencies from dotnet/roslyn #37781

wants to merge 14 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 4, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 03acf5d2-59bd-494b-c390-08d8e9750d9d
  • Build: 20240111.4
  • Date Produced: January 11, 2024 8:34:29 PM UTC
  • Commit: 514b5364881b9a36a2630ab7c0160f8e642fc1b3
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
7017f5c 
…104.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.3
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jan 4, 2024
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 5, 2024

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure-current-swat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
68a7a59 
…104.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
43ad7ec 
…104.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
57d9d44 
…104.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
8572b31 
…104.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.9.0-3.24054.13
@Forgind
Copy link
Member

Forgind commented Jan 5, 2024

This should be resolved when dotnet/roslyn#71444 flows to roslyn:main then here.

ViktorHofer
ViktorHofer reviewed Jan 10, 2024
View reviewed changes
src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj Outdated
@@ -141,7 +141,7 @@
<ExpectedDependencies Include="Microsoft.Deployment.DotNet.Releases, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" />
<ExpectedDependencies Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed" />
<ExpectedDependencies Include="Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
<ExpectedDependencies Include="System.Collections.Immutable, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
<ExpectedDependencies Include="System.Collections.Immutable, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rainersigwald

In reaction to roslyn and msbuild now targeting SCI and SRM 8.0.0.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 10, 2024 •
edited
Loading

C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: The "GenerateClsidMap" task failed unexpectedly. [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: System.MissingMethodException: Method not found: 'Void Microsoft.NET.HostModel.ComHost.ClsidMap.Create(System.Reflection.Metadata.MetadataReader, System.String)'. [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: at Microsoft.NET.Build.Tasks.GenerateClsidMap.ExecuteCore() [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskBase.Execute() in //src/Tasks/Common/TaskBase.cs:line 50 [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskWithAssemblyResolveHooks.Execute() in //src/Tasks/Common/TaskWithAssemblyResolveHooks.cs:line 49 [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
C:\h\w\A58E0918\p\d\sdk\9.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(784,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.d__26.MoveNext() [C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj]
Done Building Project "C:\h\w\A58E0918\t\dotnetSdkTests\tojrsr1m.2t1\win-x64_Given---8C6CB735\ComServer.csproj" (Build target(s)) -- FAILED.

@marcpopMSFT hit that issue in the past when he tried to upgrade SRM and SCI to 7.0.0.0. There must be some incoherency in the test that I don't understand.

@ViktorHofer
Copy link
Member

cc @jaredpar

@jaredpar
Copy link
Member

The GenerateClsidTask has special resolve semantics for SCI, guessing htat is related here

https://source.dot.net/#Microsoft.NET.Build.Tasks/TaskWithAssemblyResolveHooks.cs,34ca9cc2f62f7509

@rainersigwald rainersigwald mentioned this pull request Jan 10, 2024
Merged
@ViktorHofer
Copy link
Member

This will be unblocked with #37913

dotnet-maestro bot and others added 3 commits January 12, 2024 10:34
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
ce1a7f8 
…111.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-3.24053.1 -> To Version 4.10.0-1.24061.4
@ViktorHofer
Merge branch 'main' into darc-main-8a7e000c-7b46-41df-8fbc-37d8a25cae57
1119dbc
@ViktorHofer
Merge remote-tracking branch 'origin/main' into darc-main-8a7e000c-7b…
d134f27 
…46-41df-8fbc-37d8a25cae57
@ViktorHofer ViktorHofer deleted the darc-main-8a7e000c-7b46-41df-8fbc-37d8a25cae57 branch January 12, 2024 11:59
@ViktorHofer
Copy link
Member

Added dependencies into #37913

@build-analysis build-analysis bot mentioned this pull request Jan 12, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Forgind @ViktorHofer @jaredpar @v-wuzhai